New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
atomic.AddUint64 in 32-bit cause panic #4111
Labels
Comments
Similar questions: rs/zerolog#228 |
miekg
added a commit
that referenced
this issue
Sep 9, 2020
A 64 bit entity needs to be the first in a struct to make it work on 32 bit systems. Fixes: #4111 Signed-off-by: Miek Gieben <miek@miek.nl>
[ Quoting <notifications@github.com> in "Re: [coredns/coredns] atomic.AddUin..." ]
Similar questions: rs/zerolog#228
Reason: https://golang.org/pkg/sync/atomic/#pkg-note-BUG
Possible solution: rs/zerolog#229
or just changing count to an uint32 instead
the struct alignment is wrong, see #4112
|
miekg
added a commit
that referenced
this issue
Sep 9, 2020
* plugin/trace: fix struct allignment A 64 bit entity needs to be the first in a struct to make it work on 32 bit systems. Fixes: #4111 Signed-off-by: Miek Gieben <miek@miek.nl> * plugin/erratic does makes the same mistake Signed-off-by: Miek Gieben <miek@miek.nl>
nyodas
pushed a commit
to DataDog/coredns
that referenced
this issue
Oct 26, 2020
* plugin/trace: fix struct allignment A 64 bit entity needs to be the first in a struct to make it work on 32 bit systems. Fixes: coredns#4111 Signed-off-by: Miek Gieben <miek@miek.nl> * plugin/erratic does makes the same mistake Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened:
atomic.AddUint64 in 32-bit cause panic
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
GOARCH=386 go run coredns.go
Anything else we need to know?:
Environment:
cat /etc/os-release
): Linux elk-141 4.9.6-200.2.el7.xxx.x86_64 Clean up the docs and remove reference to Caddy #1 SMP Wed Mar 1 18:39:23 CST 2017 x86_64 x86_64 x86_64 GNU/LinuxThe text was updated successfully, but these errors were encountered: