Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Set microsencods precision as default value for datetime columns" #3

Closed
wants to merge 1 commit into from
Closed

Revert "Set microsencods precision as default value for datetime columns" #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/cookpad_mysql_defaults.rb
View file
Open in desktop
@@ -1,6 +1,4 @@
require "cookpad_mysql_defaults/mysql_table_default_options"
require "cookpad_mysql_defaults/table_definition"
require "cookpad_mysql_defaults/schema_statements"
Comment on lines -2 to -3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think reverting this is a good idea, since this may break other Rails 6 app that relies on this flag too.

What about requiring the code if AR version is less than 7?

if ActiveRecord::VERSION::MAJOR < 7
  require "cookpad_mysql_defaults/table_definition"
  require "cookpad_mysql_defaults/schema_statements"
end


module CookpadMysqlDefaults
end
32 changes: 0 additions & 32 deletions lib/cookpad_mysql_defaults/schema_statements.rb
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions lib/cookpad_mysql_defaults/table_definition.rb
View file
Open in desktop

This file was deleted.