Revert "Set microsencods precision as default value for datetime columns" #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mns" This reverts commit eafa459.
robertomiranda
requested review from
sikachu,
a team,
alinagrishchuk and
errm
and removed request for
a team
sikachu
suggested changes
Mar 2, 2022
Comment on lines
-2
to
-3
| require "cookpad_mysql_defaults/table_definition" | ||
| require "cookpad_mysql_defaults/schema_statements" |
There was a problem hiding this comment.
I don't think reverting this is a good idea, since this may break other Rails 6 app that relies on this flag too.
What about requiring the code if AR version is less than 7?
if ActiveRecord::VERSION::MAJOR < 7
require "cookpad_mysql_defaults/table_definition"
require "cookpad_mysql_defaults/schema_statements"
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit eafa459. Already part of Rails 7 rails/rails#42297