Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since it doesn't work well anyway,let's replace it #3141

Merged
merged 1 commit into from May 1, 2022
Merged

Since it doesn't work well anyway,let's replace it #3141

merged 1 commit into from May 1, 2022

Conversation

sdzialowski-godaddy
Copy link
Contributor

Process of registering commit-msg hook doesn't seem to be reliable, let's maybe replace it with solution suggested in other PR #3113

Description

Motivation and Context

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Member

Amazing how complicated this gets 😢

Would you mind separating the code block so that the extended "Add hook" part has it's individual box(es). In that way people can just click
image
and paste it into their terminal.
Makes it easier for people who are new to this.

Last thing, please modify the commit to be conform with https://www.conventionalcommits.org

Thanks for your support!

@sdzialowski-godaddy
Copy link
Contributor Author

Should be ok now

@escapedcat
Copy link
Member

Uhm, sorry. It's not a fix really. It's just an update of the docs:. This should not affect an upcoming new version.

Would be good to separate this big code block into multiple parts which can easily be copied (and pasted):

image

It's ok if you don't have time for that. I can do it.

@escapedcat escapedcat merged commit 552593b into conventional-changelog:master May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants