Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forgotten "chmod +x" to previous PR #3140

Closed
wants to merge 1 commit into from
Closed

forgotten "chmod +x" to previous PR #3140

wants to merge 1 commit into from

Conversation

sdzialowski-godaddy
Copy link
Contributor

Description

Fix to #3113

Motivation and Context

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Member

Please change the commit message to docs: add chmod +x to be conform with https://www.conventionalcommits.org , thanks!

@sdzialowski-godaddy
Copy link
Contributor Author

Should be ok now

@escapedcat
Copy link
Member

Uhm, sorry. It's not a fix really. It's just an update of the docs:. This should not affect an upcoming new version.

@escapedcat
Copy link
Member

Replaced by #3141 I believe

@escapedcat escapedcat closed this May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants