fix: usage of axios [PHX-2738] #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreascful
approved these changes
Jul 17, 2023
marcolink
changed the title
damienxy
approved these changes
Jul 19, 2023
|
馃帀 This PR is included in version 8.1.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
ruderngespra
added a commit
that referenced
this pull request
Nov 29, 2023
We reintroduce the `paramsSerializer` (again) after removing it [here](#370). This is to unblock [the axios bump in contentful-merge](contentful/contentful-merge#462) or the skd-core bump [as such](contentful/contentful-merge#552). We saw that tests were failing because the query set together [here](https://github.com/contentful/contentful-merge/blob/main/src/engine/create-changeset/tasks/create-fetch-partial-entities-task.ts#L43) can not properly be handled by the API anymore and instead runs into `error: InvalidQuery: The query you sent was invalid. Probably a filter or ordering specification is not applicable to the type of a field.` Tested locally on `contentful.js` and `contentful-merge`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every major version bump needs to be followed by a fix 馃檲
Changes
headers type
Internally we always initialise an
AxiosHeadersobject by defaultCustom error type
The newly introduced error type had an
unknownprop. We changed it toanyfor simplicity.Remove
paramsSerializeragainWe provided a custom
paramsSerializerprop based on this discussion. At the time released (with latestaxios@1.4.0), this is not required anymore, thanks to this fix.Testing
These changes are manually tested against contentful.js and contentful-management.js. As soon as this is released, we can create PRs for both projects.
Migration Learnings
I also started a little doc for all the findings.