fix: re-introduce paramsSerializer #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruderngespra
force-pushed
the
fix/reintroduce-params-serializer
branch
2 times, most recently
from
87dea34
to
6a5bdbd
Compare
ruderngespra
force-pushed
the
fix/reintroduce-params-serializer
branch
from
6a5bdbd
to
941962d
Compare
|
Will tackle this after next tuesday! |
|
Tested locally on |
|
Once this is merged, we should trigger dependabot on all the mentioned repositories above, and for |
mayakarabula
approved these changes
Nov 29, 2023
|
🎉 This PR is included in version 8.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We reintroduce the
paramsSerializer(again) after removing it here.This is to unblock the axios bump in contentful-merge or the skd-core bump as such. We saw that tests were failing because the query set together here can not properly be handled by the API anymore and instead runs into
error: InvalidQuery: The query you sent was invalid. Probably a filter or ordering specification is not applicable to the type of a field.Tested locally on
contentful.jsandcontentful-merge