Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toml decoding: report unknown keys #1507

Merged
merged 1 commit into from Mar 28, 2022
Merged

Commits on Mar 28, 2022

  1. toml decoding: report unknown keys

    Despite the desire in containers#1284 to report unknown-key errors (e.g., for
    typos), only log them on the debug level.  We have made rather bad
    experiences with containers.conf which initially logged these errors
    on the warning level which caused an immense noise for users.
    
    The underlying problem is that not all tools are updated in sync,
    especially for non-{CentOS,Fedora,RHEL} distributions.  Config files
    changes for tools with an updated conf will hence cause noise for others
    etc.
    
    However, logging these error on the debug level will still improve user
    experience and be especially helpful in analyzing users issues.
    
    Fixes: containers#1284
    Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
    vrothberg committed Mar 28, 2022
    Copy the full SHA
    3a98f8f View commit details
    Browse the repository at this point in the history