toml decoding: report unknown keys #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
mtrmac
reviewed
Mar 25, 2022
Despite the desire in containers#1284 to report unknown-key errors (e.g., for typos), only log them on the debug level. We have made rather bad experiences with containers.conf which initially logged these errors on the warning level which caused an immense noise for users. The underlying problem is that not all tools are updated in sync, especially for non-{CentOS,Fedora,RHEL} distributions. Config files changes for tools with an updated conf will hence cause noise for others etc. However, logging these error on the debug level will still improve user experience and be especially helpful in analyzing users issues. Fixes: containers#1284 Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the desire in #1284 to report unknown-key errors (e.g., for
typos), only log them on the debug level. We have made rather bad
experiences with containers.conf which initially logged these errors
on the warning level which caused an immense noise for users.
The underlying problem is that not all tools are updated in sync,
especially for non-{CentOS,Fedora,RHEL} distributions. Config files
changes for tools with an updated conf will hence cause noise for others
etc.
However, logging these error on the debug level will still improve user
experience and be especially helpful in analyzing users issues.
Fixes: #1284
Signed-off-by: Valentin Rothberg vrothberg@redhat.com
@mtrmac @rhatdan PTAL