[v5.19, backport] storage: use race-free AddNames instead of SetNames
#1503
Conversation
Signed-off-by: Aditya R <arajan@redhat.com>
Commits from parallel builds using `SetNames` removes `names` from storage for other builds. Use race-free atomic `AddNames` to prevent breaking of parallel builds. Signed-off-by: Aditya R <arajan@redhat.com>
Signed-off-by: Aditya R <arajan@redhat.com>
|
@mtrmac @vrothberg PTAL this backports the needed commit, could we cut a |
|
I think CI is not getting triggered because of github outage or could it be something else ? |
Sure. Would you like to prepare the usual two-commit PR? Compare https://github.com/containers/image/pull/1457/commits . |
|
@mtrmac I have added two consecutive commits in this same PR, i wonder if i just need to add |
Signed-off-by: Aditya R <arajan@redhat.com>
|
@mtrmac bumped to |
|
I was kinda thinking of a separate PR, but this works just as well and saves us some CI time. |
|
@mtrmac tests are green now :D |
|
https://github.com/containers/image/releases/tag/v5.19.2 tagged. Thanks! |
|
Partially addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2066519 and https://bugzilla.redhat.com/show_bug.cgi?id=2055487 |
|
Exceptions approved: RHEL 9.0 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2066519 RHEL 8.6 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2055487 |
Backport of: #1480
Commits from parallel builds using
SetNamesremovesnamesfromstorage for other builds.
Use race-free atomic
AddNamesto prevent breaking of parallel builds.