[v5.10, backport] storage: use race-free AddNames instead of SetNames
#1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commits from parallel builds using `SetNames` removes `names` from storage for other builds. Use race-free atomic `AddNames` to prevent breaking of parallel builds. Signed-off-by: Aditya R <arajan@redhat.com>
Signed-off-by: Aditya R <arajan@redhat.com>
|
Wait for release of |
mtrmac
reviewed
Apr 6, 2022
| @@ -31,7 +31,7 @@ require ( | |||
| github.com/pquerna/ffjson v0.0.0-20190813045741-dac163c6c0a9 // indirect | |||
| github.com/sirupsen/logrus v1.7.0 | |||
| github.com/stretchr/testify v1.7.0 | |||
| github.com/ulikunitz/xz v0.5.9 | |||
| github.com/ulikunitz/xz v0.5.10 | |||
There was a problem hiding this comment.
Just to be explicit, this c/storage change will drag in a bit more than just AddNames. It’s still on the 1.24 branch of c/storage, so hopefully fine.
mtrmac
reviewed
Apr 6, 2022
|
@flouthoc the tests will probably need a bit (hopefully not a lot?) of updates to pass. |
|
This is wrong backport since we are doing this for |
|
Creating a similar for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: #1480
Similar to: #1503
Commits from parallel builds using SetNames removes names from
storage for other builds.
Use race-free atomic AddNames to prevent breaking of parallel builds.
Needed for: BZ 2066364