Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a potential change in behavior; previously we would consider the command to be idempotent; it would ignore the error if it's not found, and print the
target
(line 180/182 below).With this change, it's no longer considered idempotent, and printing a warning; printing a warning may be ok, but the
continue
here also means that it's no longer printing the target.I realise
ctr
is a debugging tool, so not considered "stable", but wondering if there's a potential for scripts to be depending on this (i.e.target
to be printed).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for explaining. yes there's a potential breaking change for idempotency in outputs with this pr.