raise warning if ns is missing #10135
Conversation
|
Hi @ksdpmx. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: jasonz <ksdpmx@gmail.com>
| @@ -173,8 +173,10 @@ var removeCommand = &cli.Command{ | |||
| } | |||
| log.G(ctx).WithError(err).Errorf("unable to delete %v", target) | |||
| continue | |||
| } else { | |||
| log.G(ctx).WithError(err).Warnf("namespace %v not found", target) | |||
| continue | |||
There was a problem hiding this comment.
This looks like a potential change in behavior; previously we would consider the command to be idempotent; it would ignore the error if it's not found, and print the target (line 180/182 below).
With this change, it's no longer considered idempotent, and printing a warning; printing a warning may be ok, but the continue here also means that it's no longer printing the target.
I realise ctr is a debugging tool, so not considered "stable", but wondering if there's a potential for scripts to be depending on this (i.e. target to be printed).
There was a problem hiding this comment.
thanks for explaining. yes there's a potential breaking change for idempotency in outputs with this pr.
Currently there's no difference in output whether ns is existed or not.
This minor pr helps improve UX.