Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vue-svg-loader and upgrade Vue CLI #53

Merged
merged 5 commits into from
May 14, 2022
Merged

Use vue-svg-loader and upgrade Vue CLI #53

merged 5 commits into from
May 14, 2022

Commits on May 14, 2022

  1. Use vue-svg-loader instead of html-loader for loading SVGs. 

    It appears to work identically to the html-loader implementation I had
previously, but this one hopefully won't break upon subsequent upgrades
to Vue CLI.
    @connorshea
    connorshea committed May 14, 2022
    Configuration menu
    Copy the full SHA
    b366a20 View commit details
    Browse the repository at this point in the history

  2. Upgrade Vue CLI to 5.0.4 and get SVGs working with it. 

    This was very annoying to make work. Also the vglist logo doesn't
render, but that was a problem introduced by the previous commit, so
YOLO.
    @connorshea
    connorshea committed May 14, 2022
    Configuration menu
    Copy the full SHA
    a8ad3f2 View commit details
    Browse the repository at this point in the history

  3. Fix loading the vglist logo. 

    We don't want to treat it in a special way like the other icons, so
move it to the public directory.

I chose this solution based on these docs:
https://cli.vuejs.org/guide/html-and-static-assets.html#the-public-folder
    @connorshea
    connorshea committed May 14, 2022
    Configuration menu
    Copy the full SHA
    6b7db1b View commit details
    Browse the repository at this point in the history

  4. Remove html-loader, since it's no longer necessary.

    @connorshea
    connorshea committed May 14, 2022
    Configuration menu
    Copy the full SHA
    0d98837 View commit details
    Browse the repository at this point in the history

  5. Fix warnings printed in the Jest specs. 

    Jest didn't know how to load the SVGs as components, so I'm having it
ignore SVGs entirely instead.
    @connorshea
    connorshea committed May 14, 2022
    Configuration menu
    Copy the full SHA
    019f4f8 View commit details
    Browse the repository at this point in the history