Use vue-svg-loader and upgrade Vue CLI #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears to work identically to the html-loader implementation I had previously, but this one hopefully won't break upon subsequent upgrades to Vue CLI.
This was very annoying to make work. Also the vglist logo doesn't render, but that was a problem introduced by the previous commit, so YOLO.
We don't want to treat it in a special way like the other icons, so move it to the public directory. I chose this solution based on these docs: https://cli.vuejs.org/guide/html-and-static-assets.html#the-public-folder
Jest didn't know how to load the SVGs as components, so I'm having it ignore SVGs entirely instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to upgrade Vue CLI past 5.0.0-beta.6 because beta 7 removed file-loader support, which broke html-loader. html-loader is how I've been making SVGs work because I had tried vue-svg-loader before, and it didn't work for whatever reason. Thankfully the transition from one to the other wasn't too bad, and all the weird stuff I was doing to style the SVGs still works fine with this slot hack I've updated the SvgIcon component to use.