Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate breakage with setuptools=66 (DNM) #4732

Closed
wants to merge 3 commits into from

Conversation

jaimergp
Copy link
Contributor

Description

Checking whether this is breaking for conda-build too, or just conda-smithy. See conda-forge/conda-forge-pinning-feedstock#3973.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 19, 2023
@jaimergp
Copy link
Contributor Author

Confirmed breakage:

______________________ test_pypi_section_order_preserved _______________________
[gw1] linux -- Python 3.8.16 /usr/share/miniconda/envs/test/bin/python
Traceback (most recent call last):
  File "/home/runner/work/conda-build/conda-build/src/tests/test_api_skeleton.py", line 429, in test_pypi_section_order_preserved
    api.skeletonize(packages='sympy', repo='pypi')
  File "/home/runner/work/conda-build/conda-build/src/conda_build/api.py", line 270, in skeletonize
    skeleton_return = module.skeletonize(packages, output_dir=output_dir, version=version,
  File "/home/runner/work/conda-build/conda-build/src/conda_build/skeletons/pypi.py", line 280, in skeletonize
    versions = sorted(pypi_data["releases"].keys(), key=parse_version)
  File "/usr/share/miniconda/envs/test/lib/python3.8/site-packages/pkg_resources/_vendor/packaging/version.py", line 266, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
pkg_resources.extern.packaging.version.InvalidVersion: Invalid version: '0.5.13-hg'

and similar.

@jaimergp
Copy link
Contributor Author

A possible fix is to stop relying on the legacy and deprecated pkg_resources.parse_version behaviour and use the modern packaging.Version (see pypa/setuptools#2497 and pypa/packaging#407)

@jaimergp jaimergp mentioned this pull request Jan 19, 2023
2 tasks
@jezdez
Copy link
Member

jezdez commented Jan 20, 2023

Closing in favor of #4443

@jezdez jezdez closed this Jan 20, 2023
@jezdez
Copy link
Member

jezdez commented Jan 20, 2023

Confirmed breakage:

______________________ test_pypi_section_order_preserved _______________________
[gw1] linux -- Python 3.8.16 /usr/share/miniconda/envs/test/bin/python
Traceback (most recent call last):
  File "/home/runner/work/conda-build/conda-build/src/tests/test_api_skeleton.py", line 429, in test_pypi_section_order_preserved
    api.skeletonize(packages='sympy', repo='pypi')
  File "/home/runner/work/conda-build/conda-build/src/conda_build/api.py", line 270, in skeletonize
    skeleton_return = module.skeletonize(packages, output_dir=output_dir, version=version,
  File "/home/runner/work/conda-build/conda-build/src/conda_build/skeletons/pypi.py", line 280, in skeletonize
    versions = sorted(pypi_data["releases"].keys(), key=parse_version)
  File "/usr/share/miniconda/envs/test/lib/python3.8/site-packages/pkg_resources/_vendor/packaging/version.py", line 266, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
pkg_resources.extern.packaging.version.InvalidVersion: Invalid version: '0.5.13-hg'

and similar.

I'm so confused where 0.5.13-hg comes from, is that from PyPI?

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants