Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setuptools 66 breaks conda-build #4733

Closed
2 tasks done
jaimergp opened this issue Jan 19, 2023 · 6 comments · Fixed by #4443
Closed
2 tasks done

setuptools 66 breaks conda-build #4733

jaimergp opened this issue Jan 19, 2023 · 6 comments · Fixed by #4443
Labels
locked [bot] locked due to inactivity source::partner created by or for an Anaconda, Inc. partner company type::bug describes erroneous operation, use severity::* to classify the type

Comments

@jaimergp
Copy link
Contributor

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

Setuptools has dropped pkg_resources.parse_version legacy behaviour, so it doesn't use LegacyVersion under the hood anymore. This results in some InvalidVersion errors in the test suite: #4732

See:

Conda Info

See CI https://github.com/conda/conda-build/pull/4732

Conda Config

See CI https://github.com/conda/conda-build/pull/4732

Conda list

See CI https://github.com/conda/conda-build/pull/4732

Additional Context

This affects conda-smithy rerender too: conda-forge/conda-forge-pinning-feedstock#3973
@jaimergp jaimergp added the type::bug describes erroneous operation, use severity::* to classify the type label Jan 19, 2023
@jakirkham
Copy link
Member

Wonder if we are able to drop pkg_resources altogether

@jaimergp
Copy link
Contributor Author

xref #4443

@jakirkham jakirkham mentioned this issue Jan 20, 2023
Merged
@jakirkham
Copy link
Member

Lol had forgotten that 🤦‍♂️

@timcera timcera mentioned this issue Jan 21, 2023
Merged
5 tasks
@travishathaway travishathaway added the source::partner created by or for an Anaconda, Inc. partner company label Jan 23, 2023
@ReimarBauer
Copy link

ReimarBauer commented Jan 30, 2023 •
edited

fixating setuptools helps meanwhile

setuptools ==65.5.1

conda-forge/mss-feedstock@6fab5f0

our problem in MSS will be solved after fixing our version string, which has a tailing dot at the end.

This was referenced Jan 30, 2023
Merged
Closed
Closed
@ReimarBauer
Copy link

I have currently a follow up problem.
Usually we install our dependencies for developers by:

mamba install mss python --only-deps

The result is a broken environment. mamba is missing, conda faces inconsistancy.

We have to do now.

mamba install mss python
conda remove mss --force

Maybe this will vanish also when I fixed our version string.

@jakirkham
Copy link
Member

We need a repodata fix in conda-forge (defaults may need a similar fix)

Please see PR ( conda-forge/boa-feedstock#61 ). In particular comment ( conda-forge/boa-feedstock#61 (comment) ). Help making this change would be welcome :)

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked [bot] locked due to inactivity source::partner created by or for an Anaconda, Inc. partner company type::bug describes erroneous operation, use severity::* to classify the type
Projects
🧭 Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop dependency on Setuptools jakirkham/conda-build
4 participants
@ReimarBauer @travishathaway @jaimergp @jakirkham