New home, license, "cmake" driven build, and latest version #26

timcera · 2023-01-19T22:40:00Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged. (which license file? The only license file in the original fork is for the feedstock. Am I supposed to include the license file of the g2clib package? Pointed to it in the README.md.

conda-forge-webservices · 2023-01-19T22:40:06Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The recipe must have some tests.
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-webservices · 2023-01-20T05:14:24Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The recipe must have some tests.

conda-forge-webservices · 2023-01-20T14:42:40Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

different platforms

conda-forge-webservices · 2023-01-21T15:45:58Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The recipe must have some tests.

anyway

timcera · 2023-01-21T22:29:25Z

@conda-forge-admin, please rerender
Because of conda/conda-build#4733 and conda-forge/conda-forge-pinning-feedstock#3973 I cannot run "conda-smithy rerender".

…nda-forge-pinning 2023.01.20.05.27.27

timcera · 2023-01-21T22:59:11Z

I have carried this as far as I can.

I thought the system wouldn't try to build Windows or OSX anymore, but I must misunderstand something. The current Windows successful build is empty.

Kind regards,
Tim

recipe/meta.yaml

…whome

recipe/meta.yaml

conda-forge-webservices · 2023-01-28T01:36:52Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar · 2023-01-28T01:37:07Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2023.01.27.20.38.35

Make it more verbose, parallel and only run it when not cross compiling.

xylar · 2023-01-28T01:43:08Z

@conda-forge-admin, please rerender

xylar · 2023-01-28T01:43:53Z

That last commit refers to all unix architectures. We're still skipping Windows.

…nda-forge-pinning 2023.01.27.20.38.35

xylar · 2023-01-28T02:13:50Z

I think we'll want to wait for conda-forge/jasper-feedstock#41 to get ppc64le support. In the meantime, I'll try to get the rest of the tests working.

xylar · 2023-01-28T02:22:01Z

Failing tests for OSX may relate to old jasper, see:
NOAA-EMC/NCEPLIBS-g2c#398

xylar · 2023-01-28T02:29:09Z

@timcera, thank you for getting us this far! I wouldn't have been able to make any headway without you getting things started. The remaining problems both seem related to jasper. I'll see what I can do about them over at https://github.com/conda-forge/jasper-feedstock/pulls

xylar · 2023-02-07T04:27:44Z

OSX is installing the correct libpng:

    libpng:  1.6.39-ha978bb4_0 conda-forge

but then detects a much older version somehow in CMake:

-- Found PNG: $PREFIX/lib/libpng.dylib (found version "1.4.12")

This then seems to cause issues in testing:

test 18
      Start 18: tst_addfield2

18: Test command: $SRC_DIR/build/tests/tst_addfield2
18: Working Directory: $SRC_DIR/build/tests
18: Test timeout computed to be: 1500
17: libpng warning: Application built with libpng-1.4.12 but running with 1.6.39
17: Testing PNG functions.
17: Testing enc_png() call...-1
17/21 Test #17: tst_png ..........................***Failed    0.11 sec
libpng warning: Application built with libpng-1.4.12 but running with 1.6.39
Testing PNG functions.
Testing enc_png() call...-1

test 19
      Start 19: tst_jpeg

19: Test command: $SRC_DIR/build/tests/tst_jpeg
19: Working Directory: $SRC_DIR/build/tests
19: Test timeout computed to be: 1500
18: libpng warning: Application built with libpng-1.4.12 but running with 1.6.39
18: Testing g2_addfield() some more.
18: Testing full message creation (expect and ignore error messages)...
18: g2_addfield: Sections 4-7 can only be added after Section 3 or 7.
18: g2_addfield: Section 1 was the last found in given GRIB message.
18: g2_addfield: Section byte counts don''t add to total.
18: g2_addfield: Sum of section byte counts = 37
18: g2_addfield: Total byte count in Section 0 = 5
18: pngpack: ERROR Packing PNG = -1
18/21 Test #18: tst_addfield2 ....................***Failed    0.11 sec
libpng warning: Application built with libpng-1.4.12 but running with 1.6.39
Testing g2_addfield() some more.

I don't know that could be causing this.

xylar · 2023-02-07T04:30:21Z

@ocefpaf, you're a maintainer of libpng, though I know you're involved in a lot of packages and that doesn't mean you have to be an expert on all of them! Any guesses?

ocefpaf · 2023-02-07T15:07:55Z

@ocefpaf, you're a maintainer of libpng, though I know you're involved in a lot of packages and that doesn't mean you have to be an expert on all of them! Any guesses?

Not sure :-/ Maybe it is a bug in the cmake files?

timcera · 2023-03-08T15:19:28Z

For the osx_64 build only, would it make sense to just remove the system libpng? Then the only visible libpng would be the one installed by conda.

xylar · 2023-03-08T17:26:54Z

@timcera, feel free to give that a try.

timcera · 2023-03-08T21:12:21Z

Was able to make it work with cmake keywords. https://conda-forge.org/docs/maintainer/knowledge_base.html#using-cmake

xylar · 2023-03-08T22:30:09Z

Wonderful! Thanks and welcome @timcera.

timcera added 2 commits January 19, 2023 17:24

[FIX] new home, license, "cmake" driven build, and latest version

8918ae9

[MNT] ran "conda-smithy rerender ..."

e4b1875

timcera requested review from jhamman, ocefpaf and xylar as code owners January 19, 2023 22:40

[FIX] several fixes and changes based on lint and rerender

2ff783a

timcera added 2 commits January 20, 2023 00:23

[FIX] Include pkg-config for Windows

33776be

[FIX] Possible fix for windows ci and added test section

3bf18bc

timcera added 5 commits January 20, 2023 18:07

[FIX] had to run conda-smithy again

3c35118

[FIX] attempt to fix ctest on linux and m.lib not found on windows

2f42613

[FIX] another try at fixing linux and windows

98758c4

[FIX] got ctest to work locally anyway.

68b5650

removed test section because couldn't get ctest to be reliably found on

f911b9a

different platforms

timcera added 2 commits January 21, 2023 13:54

One final try at getting windows to work.

892eee3

Removed windows and macos - weren't available in the earlier vesions

a77ab56

anyway

MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and co…

cc630ea

…nda-forge-pinning 2023.01.20.05.27.27

ocefpaf reviewed Jan 25, 2023

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

timcera added 2 commits January 25, 2023 11:48

[FIX] added required maintainers

822a8c1

Merge branch 'newhome' of github.com:timcera/g2clib-feedstock into ne…

e28d934

…whome

xylar reviewed Jan 28, 2023

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

xylar reviewed Jan 28, 2023

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

xylar added 2 commits January 28, 2023 02:34

Debug ctest failure on OSX

796f014

Skip windows and add some tests

24d1a60

conda-forge-webservices[bot] and others added 3 commits January 28, 2023 01:38

MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and co…

6522700

…nda-forge-pinning 2023.01.27.20.38.35

More changes to ctest

0110fb7

Make it more verbose, parallel and only run it when not cross compiling.

Switch back to building all architectures

b96e0d2

MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and co…

c30268c

…nda-forge-pinning 2023.01.27.20.38.35

This was referenced Jan 28, 2023

Use linux_64 to build ppc64le conda-forge/jasper-feedstock#31

Closed

Rebuild to get ppc64le package conda-forge/jasper-feedstock#41

Merged

Fix tests

466f7a8

[FIX] Found cmake options which should prevent finding system libs

d1e11d1

xylar merged commit d6c9bac into conda-forge:main Mar 8, 2023

timcera deleted the newhome branch March 24, 2023 00:20

akrherz mentioned this pull request Mar 30, 2023

Rebuild for jasper4 conda-forge/wgrib2-feedstock#28

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New home, license, "cmake" driven build, and latest version #26

New home, license, "cmake" driven build, and latest version #26

timcera commented Jan 19, 2023

conda-forge-webservices bot commented Jan 19, 2023

conda-forge-webservices bot commented Jan 20, 2023

conda-forge-webservices bot commented Jan 20, 2023

conda-forge-webservices bot commented Jan 21, 2023

timcera commented Jan 21, 2023

timcera commented Jan 21, 2023

conda-forge-webservices bot commented Jan 28, 2023

xylar commented Jan 28, 2023

xylar commented Jan 28, 2023

xylar commented Jan 28, 2023

xylar commented Jan 28, 2023

xylar commented Jan 28, 2023

xylar commented Jan 28, 2023

xylar commented Feb 7, 2023

xylar commented Feb 7, 2023 •

edited

ocefpaf commented Feb 7, 2023

timcera commented Mar 8, 2023

xylar commented Mar 8, 2023

timcera commented Mar 8, 2023

xylar commented Mar 8, 2023

New home, license, "cmake" driven build, and latest version #26

New home, license, "cmake" driven build, and latest version #26

Conversation

timcera commented Jan 19, 2023

conda-forge-webservices bot commented Jan 19, 2023

conda-forge-webservices bot commented Jan 20, 2023

conda-forge-webservices bot commented Jan 20, 2023

conda-forge-webservices bot commented Jan 21, 2023

timcera commented Jan 21, 2023

timcera commented Jan 21, 2023

conda-forge-webservices bot commented Jan 28, 2023

xylar commented Jan 28, 2023

xylar commented Jan 28, 2023

xylar commented Jan 28, 2023

xylar commented Jan 28, 2023

xylar commented Jan 28, 2023

xylar commented Jan 28, 2023

xylar commented Feb 7, 2023

xylar commented Feb 7, 2023 • edited

ocefpaf commented Feb 7, 2023

timcera commented Mar 8, 2023

xylar commented Mar 8, 2023

timcera commented Mar 8, 2023

xylar commented Mar 8, 2023

xylar commented Feb 7, 2023 •

edited