Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document missing bundled conda for self hosted runners #187

Merged
merged 3 commits into from May 26, 2022

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Aug 3, 2021

Closes #113


I think documenting the workarounds in the error message is enough for this corner case.

src/setup.ts Outdated
'If you are using this action in a self-hosted runner that already provides ' +
'its own Miniconda installation, please specify its location with a `CONDA` ' +
'environment variable. If you want us to download and install Miniconda for ' +
'you, use `miniconda-version: "latest"` in the parameters for this action.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might also want to rep miniforge-version...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops missed this, pushing now.

src/setup.ts Outdated Show resolved Hide resolved
Co-authored-by: Jaewoo Park <jaewoopark91@gmail.com>
@jaimergp
Copy link
Member Author

@goanpeca this should be ready to go

@traversaro
Copy link

fyi @singhbal-baljinder

@goanpeca goanpeca changed the base branch from master to develop May 26, 2022 16:25
@goanpeca goanpeca added this to the v2.2.0 milestone May 26, 2022
@goanpeca goanpeca merged commit 200390f into develop May 26, 2022
@goanpeca goanpeca deleted the warn-no-conda branch May 26, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle: Bundled Miniconda not found! and provide a warning and default installation
5 participants