Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo “enviroment” #250

Closed
wants to merge 1 commit into from
Closed

Fix typo “enviroment” #250

wants to merge 1 commit into from

Conversation

0x2b3bfa0
Copy link

No description provided.

mattwthompson
mattwthompson approved these changes Oct 23, 2022
View reviewed changes
Copy link

@mattwthompson mattwthompson left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Are we merging stuff like this into main or develop?

@0x2b3bfa0 0x2b3bfa0 changed the base branch from main to develop October 23, 2022 23:27
@goanpeca
Copy link
Member

develop :)

@mattwthompson
Copy link

Based on the merge conflict, it looks like this has already been fixed in develop via #187.

Do we have a process for moving things into main and releases? That typo fix is about a year and a half old, so we should probably get it out into the world soon 🙂

@0x2b3bfa0
Copy link
Author

Already fixed on the develop branch, closing unmerged as a duplicate of 8ca9e40 🙈

@0x2b3bfa0 0x2b3bfa0 closed this Oct 24, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the patch-1 branch October 24, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwthompson mattwthompson mattwthompson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0x2b3bfa0 @goanpeca @mattwthompson