Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pillow v8.2.0 #93

Merged
merged 2 commits into from May 17, 2021
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/709963631, please use this URL for debugging

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

  • packaging
  • pytest

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@kmilos
Copy link
Contributor

kmilos commented Apr 2, 2021

As mentioned here, a straight update no longer works: either patch Pillow to build w/o -DUSE_WIN32_FILEIO, or switch libtiff (and poppler) to Win32 I/O now as well.

@ocefpaf ocefpaf marked this pull request as draft April 2, 2021 17:40
@ocefpaf
Copy link
Member

ocefpaf commented Apr 2, 2021

As mentioned here, a straight update no longer works: either patch Pillow to build w/o -DUSE_WIN32_FILEIO, or switch libtiff (and poppler) to Win32 I/O now as well.

I converted it to draft to prevent an accidental merge. I don't have the time to do this at the moment but if no one beats me to it I'll try to implement that next weekend. Thanks!

@sodre sodre mentioned this pull request Apr 7, 2021
2 tasks
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The build section contained an unexpected subsection name. patches is not a valid subsection name.

This keeps things consistent with current conda-forge builds of tiff
(and poppler).
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dopplershift
Copy link
Member

@ocefpaf (or @kmilos) does this seem reasonable to you?

@dopplershift dopplershift marked this pull request as ready for review May 5, 2021 19:14
@kmilos
Copy link
Contributor

kmilos commented May 5, 2021

Should certainly work for the status quo, but depends on how LibTIFF will upgrade to 4.3 wrt to win32 i/o...

One option is to maybe have another release of Pillow 8.1.0 (and poppler) that pins to LibTIFF <= 4.2 w/o it, then simultaneously upgrade LibTIFF 4.3 w/ win32 i/o, and Pillow 8.2.0 and poppler that require >= 4.3...

@dopplershift
Copy link
Member

Are there benefits to having WIN32_FILEIO enabled?

@kmilos
Copy link
Contributor

kmilos commented May 6, 2021

Interoperability with the defaults channel and most (if not all) other LibTIFF binaries on Windows?

@ocefpaf
Copy link
Member

ocefpaf commented May 13, 2021

Interoperability with the defaults channel and most (if not all) other LibTIFF binaries on Windows?

The former is kind of hard already. The latter I would hope that we wouldn't need to worry about but I'm not a windows expert.

@kmilos
Copy link
Contributor

kmilos commented May 13, 2021

The former is kind of hard already.

Sure. IMHO it's still worthwhile to reduce the differences when possible.

The latter I would hope that we wouldn't need to worry about but I'm not a windows expert.

I recently run into a problem with the opencv conda-forge package depending on libprotobuf, and quickly learned the hard way that the Windows system folders have higher priority in dll load order than the PATH variable that is correctly set for any conda environment:

https://docs.microsoft.com/en-us/windows/win32/dlls/dynamic-link-library-search-order#search-order-for-desktop-applications

Plenty of hits out there if you try "dll hell" ;)

So, if for any reason (some unrelated and misbehaving app installer drops it in, etc.), there is a libtiff.dll in any of the Windows system folders, it will be used ahead of the conda-forge one, and you have no control over it whatsoever (apart from static linking). That other libitff.dll will more likely than not be built w/ WIN32_IO enabled (the default setting for the libtiff Windows builds).

@jan-janssen
Copy link
Member

Is it possible to merge these changes? I have two pull requests waiting for this.

@ocefpaf
Copy link
Member

ocefpaf commented May 17, 2021

Is it possible to merge these changes? I have two pull requests waiting for this.

I guess we are good to go here. @dopplershift and @kmilos, any final thoughts?

@dopplershift
Copy link
Member

Seems good to go to me.

@ocefpaf ocefpaf merged commit 126406f into conda-forge:master May 17, 2021
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 8.2.0_h485509 branch May 17, 2021 21:50
@kmilos
Copy link
Contributor

kmilos commented May 18, 2021

Alas, I think there was a missed opportunity here to simultaneously upgrade libtiff and pillow to win32 i/o here @ocefpaf @hmaarrfk

The current libtiff PR is now no longer aligned to pillow for example...

@hmaarrfk
Copy link
Contributor

@kmilos I think we will have to keep the unix_io patching for now. I set the PR as WIP to ensure it doesn't get merged accidentally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants