libtiff v4.3.0

[regro-cf-autotick-bot]

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

1. Feel free to push to the bot's branch to update this PR if needed.
2. The bot will almost always only open one PR per version.
   Checklist before merging this PR:

• Dependencies have been updated if changed: see upstream
• Tests have passed
• Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/851751651, please use this URL for debugging}

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :( Help is very welcome!

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[kmilos]

If you remove the i/o patch, pillow and poppler no longer work (known cases, there might be more), as they are currently patched for the assumption of unix i/o...

OTOH, if the libtiff changes you referred to do indeed address the win32 vs unix i/o (TBC indeed), then the pillow and poppler code using _get_osfhandle() is no longer valid and would have to be eventually removed upstream as well?

[hmaarrfk]

You are correct, their patch doesn't actually address the issue, it just hides the casting:

static inline thandle_t thandle_from_int(int ifd)
{
    return (thandle_t)(intptr_t)ifd;
}

static inline int thandle_to_int(thandle_t fd)
{
    return (int)(intptr_t)fd;
}

We need to update our patch.

[hmaarrfk]

If you could update the patch, I would be grateful.

[kmilos]

Yep, that upstream code just addresses 32/64bit Windows IPC (to preserve the old 32-bit TIFFdOpen API), but that file descriptor to Windows HANDLE translation is still necessary somewhere...

[kmilos]

Please try this updated use_unix_io.patch:

diff --git a/cmake/WindowsSupport.cmake b/cmake/WindowsSupport.cmake
index 93c1309..5a2eaa9 100644
--- a/cmake/WindowsSupport.cmake
+++ b/cmake/WindowsSupport.cmake
@@ -30,9 +30,6 @@ endif()
 
 # Win32 file I/O
 set(win32_io_default OFF)
-if(WIN32)
-    set(win32_io_default ON)
-endif()
 
 option(win32-io "Use Win32 I/O" ${win32_io_default})
 

[hmaarrfk]

thanks

[hmaarrfk]

@conda-forge-admin please rerender

[github-actions]

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

[hmaarrfk]

If you are OK with your patch, it seems to be working. I can eneable automerge.

[kmilos]

This comment no longer valid?

[hmaarrfk]

done.

[hmaarrfk]

Maybe i malformed the patch

[hmaarrfk]

we probably need to rerun the auto tools....

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

• Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [38]

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[kmilos]

Btw, why not include libdeflate, lerc, and jbig in dependencies as well, also libwebp-base on win?

[hmaarrfk]

Seems like it is good for an other PR.