Re-enable LCMS2 for Windows

[kmilos]

Checklist

• Used a personal fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[kmilos]

Any particular reason one is still checking libtiff 4.0.x on Windows, can we drop it?

AFAIK #69 is resolved and both libtiff 4.1 and 4.2 are fine on Windows...

[pkgw]

Do you know if conda-forge/libtiff-feedstock#62 has been solved?

[kmilos]

No idea to be honest... It doesn't mention a specific version problem...

#69 was fixed by making libtiff 4.1.0 and 4.2.0 behave just like 4.0.10 (as recommended by libtiff maintainers here), so I don't think there is a libtiff feedstock issue blocking this one.

poppler should probably use libtiff w/ Unix I/O just like it did for 4.0.10, no? A case statement like this is maybe needed in poppler code? I.e. patch this line the same way and add && defined(USE_WIN32_FILEIO): https://gitlab.freedesktop.org/poppler/poppler/-/blob/master/goo/TiffWriter.cc#L165

[pkgw]

OK, I'm inclined to agree that we should drop the libtiff 4.0 here, but I'm not super tuned into the ecosystem implications. @conda-forge/core anyone have any opinions about this?

[kmilos]

Yes, definitely needs to be coordinated across the whole of conda-forge: 1) stick with Unix I/O from libtiff 4.0 days and keep patching clients to match that, or 2) make a repo-wide switch to libtiff Win32 I/O

LCMS2 support is fundamentally not related to this decision (apart from misc version conflicts).

[ocefpaf]

OK, I'm inclined to agree that we should drop the libtiff 4.0 here, but I'm not super tuned into the ecosystem implications. @conda-forge/core anyone have any opinions about this?

Let's give it a try. As far as I recall we have tests in place to catch if problems occur. Hopefully we'll notice before merging.

[pkgw]

@ocefpaf You mind looking this over as a final check?

[ocefpaf]

@ocefpaf You mind looking this over as a final check?

Thanks so much for looking into this. Everything seems fine IMO, merge?