Add LittleCMS2 support. #80
Conversation
pkgw
requested review from
jakirkham,
ocefpaf,
patricksnape and
pelson
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
pillow uses the custom "PIL" license.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/core Many errors about |
|
Yep. Older setuptools fixes it on Linux. The problem on Windows is b/c we are using an older libtiff there due to #69. Not sure if we solved that or not. |
|
The changelog for setuptools 49.1.0 (cf. conda-forge/setuptools-feedstock#153) says that it reverts the distutils bundling that looks like the likely cause of the Linux issues, so we might have to wait a bit longer for that to shake out. No rush here, though. |
|
@conda-forge-admin please rerender |
…da-forge-pinning 2020.07.03.10.54.45
|
Looks like we have package conflicts for libtiff 4.0 on Windows? |
On the libtiff 4.0 variant, I get package compatibility errors:
```
Package jpeg conflicts for:
lcms2 -> jpeg[version='>=9b,<10a|>=9c,<10a|>=9d,<10a']
jpeg=9
libtiff=4.0 -> jpeg[version='9.*|>=9b,<10a|>=9c,<10a']
Package libtiff conflicts for:
libtiff=4.0
lcms2 -> libtiff[version='>=4.1.0,<5.0a0']
```
On libtiff 4.1, I get a separate issue during test (that is not obviously
related to LCMS?):
```
(%PREFIX%) %SRC_DIR%>"%PREFIX%\python.exe" -s "%SRC_DIR%\run_test.py"
import: 'PIL'
import: 'PIL.Image'
D:\bld\pillow_1593795315516\_test_env\lib\site-packages\PIL\Image.py:115: RuntimeWarning: The _imaging extension was built for another version of Pillow or PIL:
Core version: "7.2.0"
Pillow version: 7.2.0
warnings.warn(str(v), RuntimeWarning)
Traceback (most recent call last):
File "D:\bld\pillow_1593795315516\test_tmp\run_test.py", line 5, in <module>
import PIL.Image
File "D:\bld\pillow_1593795315516\_test_env\lib\site-packages\PIL\Image.py", line 100, in <module>
"Pillow version: %s" % (getattr(core, "PILLOW_VERSION", None), __version__)
ImportError: The _imaging extension was built for another version of Pillow or PIL:
Core version: "7.2.0"
Pillow version: 7.2.0
```
|
Yeah, and I ran into other issues with the libtiff 4.1 branch of the Windows builds. (See commit message.) Given that this feature seemingly isn't urgent, I just didn't enable LCMS for Windows, maintaining the status quo. With that taken care of, shall we go ahead and merge? |
|
#69 was addressed by conda-forge/libtiff-feedstock#51 AFAIK |
|
Can we try to bring back lcms2 support in Pillow please? |
|
@kmilos Sure. Would you feel comfortable preparing a pull request yourself? |
|
Sure, will try in the coming days. |
|
Ok, was quicker than I thought: #89 |
Checklist
conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Closes #58. AFAICT, this hasn't happened simply just because no one has gotten around to it?