Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jsonschema<4.17 #41

Merged
merged 3 commits into from Jan 16, 2023
Merged

Pin jsonschema<4.17 #41

merged 3 commits into from Jan 16, 2023

Conversation

jtilly
Copy link
Contributor

@jtilly jtilly commented Jan 16, 2023

altair 4.2.0 is incompatible with jsonschema>=4.17 when certain other packages are installed (e.g., rfc3339, rfc3986).

See discussion in vega/altair#2705 and vega/altair#2767.

The underlying issue was patched in vega/altair#2771 (so the jsonschema<4.17 pin can be removed in a future release of altair).

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jtilly
Copy link
Contributor Author

jtilly commented Jan 16, 2023

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest rerendering GutHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or try re-rendering locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/altair-feedstock/actions/runs/3929451359.

@ocefpaf ocefpaf merged commit b84f008 into conda-forge:main Jan 16, 2023
@@ -23,7 +23,7 @@ requirements:
- python >=3.7
- entrypoints
- jinja2
- jsonschema >=3.0
- jsonschema >=3.0,<4.17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to do a repodatapatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants