Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch jsonschema dependency for altair #385

Merged
merged 1 commit into from Jan 23, 2023

Conversation

jtilly
Copy link
Contributor

@jtilly jtilly commented Jan 16, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

altair<=4.2.0 is incompatible with jsonschema>=4.17 when certain other packages are installed (e.g., rfc3339, rfc3986).

This was fixed in the feedstock in conda-forge/altair-feedstock#41.

I'm also applying the patch from conda-forge/altair-feedstock#40 to the altair-4.2.0-pyhd8ed1ab_0 build, which added a jsonschema >=3.0 pin.

Diff:

noarch::altair-4.0.0-py_0.tar.bz2
-    "jsonschema",
+    "jsonschema <4.17",
noarch::altair-4.0.1-py_0.tar.bz2
-    "jsonschema",
+    "jsonschema <4.17",
noarch::altair-4.1.0-py_0.tar.bz2
-    "jsonschema",
+    "jsonschema <4.17",
noarch::altair-4.1.0-py_1.tar.bz2
-    "jsonschema",
+    "jsonschema <4.17",
noarch::altair-4.2.0-pyhd8ed1ab_0.tar.bz2
-    "jsonschema",
+    "jsonschema >=3.0,<4.17",
noarch::altair-4.2.0-pyhd8ed1ab_1.tar.bz2
-    "jsonschema >=3.0",
+    "jsonschema >=3.0,<4.17",

I didn't patch older versions (<4), because they're more than 3 years old and I can't reproduce the underlying issue.

cc @ocefpaf

@jtilly jtilly requested a review from a team as a code owner January 16, 2023 21:47
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk hmaarrfk closed this Jan 17, 2023
@hmaarrfk hmaarrfk reopened this Jan 17, 2023
@hmaarrfk
Copy link
Contributor

I believe you about the diff. but the bot shows otherwise. i'm trying to rerun them.

@hmaarrfk
Copy link
Contributor

There seems to be something off with the bot. Let's wait until it is resolved.

@jtilly
Copy link
Contributor Author

jtilly commented Jan 17, 2023

There seems to be something off with the bot. Let's wait until it is resolved.

Yeah, I now get the same as the bot locally.

To me it looks like we're re-applying the patch from https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/43/files.

I get the same on the main branch of this repo.

@jtilly
Copy link
Contributor Author

jtilly commented Jan 18, 2023

Rebased on main. Diff should be clean now.

@xhochy
Copy link
Member

xhochy commented Jan 23, 2023

Thanks @jtilly

@xhochy xhochy merged commit 316d0ef into conda-forge:main Jan 23, 2023
@mattijn
Copy link

mattijn commented Jan 26, 2023

Hi @jtilly, just to doublecheck: I've released an v4.2.1 hotfix (PyPI) of Altair based on your PR (vega/altair#2827, connected issue: vega/altair#2844), I assume that this will not be affected by this patch?

@jtilly
Copy link
Contributor Author

jtilly commented Jan 27, 2023

I assume that this will not be affected by this patch?

Correct! This patch only affects 4.x versions until 4.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants