Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remotes not loaded for conan alias command #8704

Merged
merged 2 commits into from Mar 26, 2021
Merged

Fix remotes not loaded for conan alias command #8704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
496b4f3
Fix remotes not loaded for alias command
kralicky Mar 25, 2021
17f4d8d
Add test
kralicky Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions conans/client/conan_api.py
View file
Open in desktop
Expand Up @@ -1166,6 +1166,8 @@ def get_path(self, reference, package_id=None, path=None, remote_name=None):

@api_method
def export_alias(self, reference, target_reference):
self.app.load_remotes()

ref = ConanFileReference.loads(reference)
target_ref = ConanFileReference.loads(target_reference)

Expand Down
13 changes: 13 additions & 0 deletions conans/test/integration/command/alias_test.py
View file
Open in desktop
Expand Up @@ -398,6 +398,19 @@ def test_repeated_alias(self):
client.run("alias Hello/0.X@lasote/channel Hello/0.2@lasote/channel")
client.run("alias Hello/0.X@lasote/channel Hello/0.3@lasote/channel")

def test_existing_python_requires(self):
# https://github.com/conan-io/conan/issues/8702
client = TestClient()
client.save({"conanfile.py": GenConanfile()})
client.run("create . test-python-requires/0.1@user/testing")
client.save({"conanfile.py": """from conans import ConanFile
class Pkg(ConanFile):
python_requires = 'test-python-requires/0.1@user/testing'"""})
client.run("create . Pkg/0.1@user/testing")
client.run("alias Pkg/0.1@user/testing Pkg/0.2@user/testing", assert_error=True)
self.assertIn("ERROR: Reference 'Pkg/0.1@user/testing' is already a package",
client.out)

def test_basic(self):
test_server = TestServer()
servers = {"default": test_server}
Expand Down