Fix remotes not loaded for conan alias command #8704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Mar 25, 2021
There was a problem hiding this comment.
Thanks @cobalt77 for contributing this!
Could you please try to add a test that checks this is working? It will help to keep it working in the future and not break it. The ConanAliasTest in command/alias_test.py would be a good place. Please let me know if you need help with it.
|
All set - note that the issue was slightly different than I originally thought but the fix is the same. I updated #8702 with details. |
memsharded
approved these changes
Mar 26, 2021
memsharded
added a commit
that referenced
this pull request
Mar 27, 2021
* Added existing tests to CMakeDeps and fixed some things about it (#8697) * Added existing tests to CMakeDeps and fixed some things about it * Review and fixed name of data file * Removed wrong comment and fixed test by declaring filenames only for CMakeDeps * new makefile_gen (#8705) * new makefile_gen * pytest mark reason * Fix remotes not loaded for conan alias command (#8704) * Fix remotes not loaded for alias command * Add test * adding diamond visits and avoid repetitions (#8701) * Start using ConanFileDependencies in msbuilddeps (#8706) * start using ConanFileDependencies in MSBuildDeps generator * full usage of ConanFileDependencies * fix intel imports * More fine-grained control (using [conf]) for build parallelization (#8665) * first shot * format the strings * package_id change due to msbuild property name change * do not fallback to cpu_count * remove parallel from constructor * remove change not needed * add unittesting * check once for parallel * Update conans/test/unittests/tools/microsoft/test_msbuild.py Co-authored-by: James <james@conan.io> Co-authored-by: James <james@conan.io> Co-authored-by: Luis Martinez de Bartolome Izquierdo <lasote@gmail.com> Co-authored-by: Joe <8194899+cobalt77@users.noreply.github.com> Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: remotes not being loaded for the
conan aliascommand, which was preventingconan aliasfrom working if python_requires is used.Docs: Omit
Fixes #8702
Fix remotes not being loaded for the
conan aliascommand, which waspreventingcausing a stack trace to be printed instead of the actual error messageconan aliasfrom working if python_requires is used.developbranch, documenting this one.