Update just in mode install and don't fail if mode check for tools.system.package_manager #11712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
reviewed
Jul 27, 2022
lasote
approved these changes
Jul 27, 2022
memsharded
approved these changes
Jul 27, 2022
1 task
feltech
added a commit
to feltech/OpenAssetIO
that referenced
this pull request
Jul 27, 2022
Due to a new `xorg/system` recipe, which the cpython recipe depends on, the `conan install` step on CI (and Vagrant) fails attempting to install system packages (i.e. `apt` packages). This is because the `xorg/system` recipe has been refactored and will now always try to install the latest version of system packages, even if they are already available. The default conan mode in this case is to only "check" if packages are installed and throw an error if they're not found (the alternative behaviour being to "install" if not found). However, this has a bug (reported and hopefully fixed in conan-io/conan#11712), whereby if the recipe has specified to `apt-get update` (or platform-specific equivalent) before installing, then conan always tries and throws an error if in "check" mode. So switch to "install" mode, which will cause a pointless `apt-get update` followed by > xorg/system: System requirements: already installed during the conan install. Added a TODO to revisit this once conan 1.51 is released, where this problem should be fixed. Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech
added a commit
to feltech/OpenAssetIO
that referenced
this pull request
Jul 27, 2022
Due to a new `xorg/system` recipe, which the cpython recipe depends on, the `conan install` step on CI (and Vagrant) fails attempting to install system packages (i.e. `apt` packages). This is because the `xorg/system` recipe has been refactored and will now always try to install the latest version of system packages, even if they are already available. The default conan mode in this case is to only "check" if packages are installed and throw an error if they're not found (the alternative behaviour being to "install" if not found). However, this has a bug (reported and hopefully fixed in conan-io/conan#11712), whereby if the recipe has specified to `apt-get update` (or platform-specific equivalent) before installing, then conan always tries and throws an error if in "check" mode. So switch to "install" mode, which will cause a pointless `apt-get update` followed by > xorg/system: System requirements: already installed during the conan install. Also extracted the list of system packages required by the latest `xorg/system` recipe and updated the package list in our bootstrap script. Added a TODO to revisit this once conan 1.51 is released, where this problem should be fixed. Signed-off-by: David Feltell <david.feltell@foundry.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Do the package manager update just in mode
installand ignore if mode ischeck.Docs: conan-io/docs#2663
Just checking if this may make more sense than raising an exception if
mode=checkandupdate=Truebecause unless you usemode=installyou will never check if the packages are installed.Closes: #11706