[Tests] Fix conan install of cpython #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a new `xorg/system` recipe, which the cpython recipe depends on, the `conan install` step on CI (and Vagrant) fails attempting to install system packages (i.e. `apt` packages). This is because the `xorg/system` recipe has been refactored and will now always try to install the latest version of system packages, even if they are already available. The default conan mode in this case is to only "check" if packages are installed and throw an error if they're not found (the alternative behaviour being to "install" if not found). However, this has a bug (reported and hopefully fixed in conan-io/conan#11712), whereby if the recipe has specified to `apt-get update` (or platform-specific equivalent) before installing, then conan always tries and throws an error if in "check" mode. So switch to "install" mode, which will cause a pointless `apt-get update` followed by > xorg/system: System requirements: already installed during the conan install. Also extracted the list of system packages required by the latest `xorg/system` recipe and updated the package list in our bootstrap script. Added a TODO to revisit this once conan 1.51 is released, where this problem should be fixed. Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech
force-pushed
the
work/fixConanInstall
branch
from
5990645
to
d9b1870
Compare
foundrytom
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
Sigh, but excellent work investigating + fixing 👍 thanks @feltech.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a new
xorg/systemrecipe, which the cpython recipe depends on, theconan installstep on CI (and Vagrant) fails attempting to install system packages (i.e.aptpackages).This failure only occurred recently due to our GitHub CI cache being busted (a separate mystery).
The primary cause of the failure is because the
xorg/systemrecipe has been refactored and will now always try to install the latest version of system packages, even if they are already available.The default conan mode in this case is to only "check" if packages are installed and throw an error if they're not found (the alternative behaviour being to "install" if not found).
However, this has a bug (reported and hopefully fixed in conan-io/conan#11712), whereby if the recipe has specified to
apt-get update(or platform-specific equivalent) before installing, then conan always tries and throws an error if in "check" mode:So switch to "install" mode, which will cause a pointless
apt-get updatefollowed byduring the conan install.
Added a TODO to revisit this once conan 1.51 is released, where this problem should be fixed.
Also extracted the list of system packages required by the latest
xorg/systemrecipe and updated the package list in our bootstrap script.