[dev2] Components requires loop #11662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
requested changes
Jul 18, 2022
franramirez688
commented
Jul 19, 2022
| assert "ERROR: There is a dependency loop in 'self.cpp_info.components' requires:" in c.out | ||
| assert "a requires c" | ||
| assert "b requires a" | ||
| assert "c rquires b" |
There was a problem hiding this comment.
with the c.run("******", assert_error=True) those asserts are never reached. Apart from that, the last asserts were testing nothing.
memsharded
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Bringing back the components requires detection loop code.
Closes: #11549
Docs: omit