Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Components cycles not detected #11549

Closed
memsharded opened this issue Jun 29, 2022 · 1 comment · Fixed by #11662
Closed

[bug] Components cycles not detected #11549

memsharded opened this issue Jun 29, 2022 · 1 comment · Fixed by #11662
Assignees
@franramirez688
Milestone
2.0.0-beta2

Comments

@memsharded
Copy link
Member

Conan 1.50 introduced a new message for loop detection in components in #11519

This had been removed in 2.0, so the test fails, it is:

@pytest.mark.xfail(reason="The detection of cycles have been removed in 2.0, this test hangs")
def test_components_cycles():

The test hangs forever, we need to change the algorithm and raise the error message again
@memsharded memsharded added this to the 2.0.0-beta2 milestone Jun 29, 2022
@franramirez688 franramirez688 self-assigned this Jul 6, 2022
@franramirez688 franramirez688 mentioned this issue Jul 18, 2022
Merged
@franramirez688 franramirez688 linked a pull request Jul 18, 2022 that will close this issue
[dev2] Components requires loop #11662
Merged
@memsharded
Copy link
Member Author

Closed by #11662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franramirez688 franramirez688

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta2
Development

Successfully merging a pull request may close this issue.

[dev2] Components requires loop franramirez688/conan
2 participants
@franramirez688 @memsharded