New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qmake: fix sharedlinkFlags and exelinkflags #9568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Link to qmake variables for reference: https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-lflags-shlib
Is it urgent or blocking? we are going to do a patch 1.40.1 release, worth moving to it?
it's blocking conan-io/conan-center-index#7222, so the sooner the better |
Ok, please move if possible the PR to the |
ok, I think it should be ok now ? nothing messed-up here ? |
Changelog: Bugfix: The qmake generator now assigns
QMAKE_LFLAGS_SHLIB
andQMAKE_LFLAGS_APP
variables instead of the incorrectQMAKE_LFLAGS
following the official docs.Docs: conan-io/docs#2224
Link to qmake documentation: https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-lflags-shlib
related to conan-io/conan-center-index#7222