Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmake: fix sharedlinkFlags and exelinkflags #9568

Merged
merged 1 commit into from Sep 10, 2021
Merged

qmake: fix sharedlinkFlags and exelinkflags #9568

merged 1 commit into from Sep 10, 2021

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Sep 9, 2021

Changelog: Bugfix: The qmake generator now assigns QMAKE_LFLAGS_SHLIB and QMAKE_LFLAGS_APP variables instead of the incorrect QMAKE_LFLAGS following the official docs.
Docs: conan-io/docs#2224

Link to qmake documentation: https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-lflags-shlib

related to conan-io/conan-center-index#7222

@ericLemanissier ericLemanissier marked this pull request as ready for review September 9, 2021 12:02
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
Link to qmake variables for reference: https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-lflags-shlib

Is it urgent or blocking? we are going to do a patch 1.40.1 release, worth moving to it?

@memsharded memsharded added this to the 1.41 milestone Sep 9, 2021
@ericLemanissier
Copy link
Contributor Author

it's blocking conan-io/conan-center-index#7222, so the sooner the better

@memsharded memsharded changed the base branch from develop to release/1.40 September 9, 2021 17:14
@memsharded memsharded changed the base branch from release/1.40 to develop September 9, 2021 17:14
@memsharded
Copy link
Member

it's blocking conan-io/conan-center-index#7222, so the sooner the better

Ok, please move if possible the PR to the release/1.40 branch if you can (if you can't dont worry, we will manage). Thanks!

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2021

CLA assistant check
All committers have signed the CLA.

@ericLemanissier ericLemanissier changed the base branch from develop to release/1.40 September 9, 2021 17:43
@ericLemanissier
Copy link
Contributor Author

ok, I think it should be ok now ? nothing messed-up here ?

@memsharded memsharded merged commit da49f32 into conan-io:release/1.40 Sep 10, 2021
@ericLemanissier ericLemanissier deleted the patch-1 branch September 10, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants