Workaround for conan qmake generator bug which causes failure to build QWT dll #7232
Conversation
|
|
This comment has been minimized.
This comment has been minimized.
|
I detected other pull requests that are modifying qwt/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Yes. For good measure, I just tested it again for shared/non-shared and debug/release permutations. |
| @@ -87,8 +87,15 @@ def _patch_qwt_config_files(self): | |||
| qwtbuild += "CONFIG += force_debug_info\n" | |||
| tools.save(qwtbuild_path, qwtbuild) | |||
|
|
|||
| def _patch_qmake_generator_files(self): | |||
| # Work around the qmake generator bug (https://github.com/conan-io/conan/pull/9568) which | |||
There was a problem hiding this comment.
The PR is now merged. How fast are you able to update your Conan client(s), when it will be released?
There was a problem hiding this comment.
Some weeks. We usually wait for a minor (fix) version.
There was a problem hiding this comment.
Seems like this was released? https://github.com/conan-io/conan/releases/tag/1.40.1
There was a problem hiding this comment.
@prince-chrismc looks to be correct.
_patch_qmake_generator_files will not break the new 1.40.1, and will allow this revision to work for previous conan versions as well. If that isn't desirable, we can cancel this PR.
There was a problem hiding this comment.
If we do ditch this change, we should replace it with:
required_conan_version = ">=1.40.1"
|
All green in build 3 (
|
Specify library name and version: qwt/6.1.6
Fixes bug that prevents building shared/DLL library on Window with Visual Studio.
When the conan PR conan-io/conan#9568 is landed, this change will still be compatible with the latest conan version, and also allow the recipe to be useful for earlier conan versions.
conan-center hook activated.