Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm-core] bring package up to date. Support for Conan 2. #22997

Open
wants to merge 56 commits into
base: master
Choose a base branch
from

Conversation

planetmarshall
Copy link
Contributor

@planetmarshall planetmarshall commented Mar 5, 2024

Specify library name and version: llvm-core/*

Attempt to bring the llvm-core recipe up to date. Includes contributions from @jusito and #17509. Fixes #20339

Note that I have opted not to add the latest version (18.1.3) as part of this PR, as the existing recipe needed updating and is already quite complex. I (or someone else) will add the latest version as a followup.


Copy link
Contributor

github-actions bot commented Mar 5, 2024

🤖 Beep Boop! This pull request is making changes to 'recipes/llvm-core//'.

👋 @Hopobcn @paulharris you might be interested. 😉

@planetmarshall planetmarshall marked this pull request as draft March 5, 2024 21:24
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@planetmarshall planetmarshall force-pushed the llvm-core-conan2 branch 3 times, most recently from b8f48e8 to 471320c Compare March 5, 2024 22:41
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@planetmarshall planetmarshall changed the title [llvm-core] bring package up to date. Initial support for 13.0.0 [llvm-core] bring package up to date. Support for Conan 2. Mar 7, 2024
@planetmarshall planetmarshall marked this pull request as ready for review March 7, 2024 22:48
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@planetmarshall
Copy link
Contributor Author

planetmarshall commented Mar 27, 2024

Could I get a second review on this? I have v18.1.1 and a Clang recipe waiting in the wings :) Pretty please!

@jwillikers
Copy link
Contributor

Could I get a second review on this? I have v18.1.1 and a Clang recipe waiting in the wings :) Pretty please!

@planetmarshall You probably want to ping one of the team members, although I think they are pretty heads-down right now fixing some of the major problems in CCI.

@planetmarshall
Copy link
Contributor Author

Could I get a second review on this? I have v18.1.1 and a Clang recipe waiting in the wings :) Pretty please!

@planetmarshall You probably want to ping one of the team members, although I think they are pretty heads-down right now fixing some of the major problems in CCI.

prince-chrismc/conan-center-index-pending-review#1 mentions 12 days before raising an alarm so I'll give it another week before pestering anyone.

@jwillikers
Copy link
Contributor

@planetmarshall Thanks for updating this recipe btw. I'm more in need of a general llvm package as the Mesa package requires some very specific components, but this really helps move things forward. Thank you!

@planetmarshall
Copy link
Contributor Author

Pinging @danimtb and @prince-chrismc for review if available.

@prince-chrismc
Copy link
Contributor

I haven't been involved in the project for a while so that table might not reflect the current trends. Nor will I be able to help with reviewing since i haven't used conan in a long while. 🙊

@planetmarshall
Copy link
Contributor Author

Pinging also @ericLemanissier and @RubenRBS

Apologies for the spam but keen to move forward with this.

Cheers.

@RubenRBS RubenRBS self-assigned this Apr 1, 2024
@ericLemanissierBot
Copy link

I detected other pull requests that are modifying llvm-core/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@planetmarshall
Copy link
Contributor Author

@RubenRBS The build seems to have been stuck in limbo for a while. Are there still CI issues? Thanks.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 26 (8c67aba9ea8aaa204b8df90f008850bd8590f8d4):

  • llvm-core/11.1.0:
    All packages built successfully! (All logs)

  • llvm-core/13.0.0:
    All packages built successfully! (All logs)

  • llvm-core/12.0.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 27 (8c67aba9ea8aaa204b8df90f008850bd8590f8d4):

  • llvm-core/13.0.0:
    All packages built successfully! (All logs)

  • llvm-core/12.0.0:
    All packages built successfully! (All logs)

  • llvm-core/11.1.0:
    All packages built successfully! (All logs)

Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!

@RubenRBS
Copy link
Member

@planetmarshall sorry about that - llvm takes quite a long time to compile - I see that the compilation is now done and the results posted and they are passing, yay!! I'll get a review going for monday, thanks a lot for your patience and for the contribution in the first place, we really aprpeciate it :)

@planetmarshall
Copy link
Contributor Author

@planetmarshall sorry about that - llvm takes quite a long time to compile - I see that the compilation is now done and the results posted and they are passing, yay!! I'll get a review going for monday, thanks a lot for your patience and for the contribution in the first place, we really aprpeciate it :)

Thanks, I also appreciate the efforts of the CCI team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llvm-core/13.0.0: recipe is broken (conan 2)
7 participants