New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llvm-core] bring package up to date. Support for Conan 2. #22997
base: master
Are you sure you want to change the base?
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/llvm-core//'. 👋 @Hopobcn @paulharris you might be interested. 😉 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b8f48e8
to
471320c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
50c4543
to
e45b3bc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Could I get a second review on this? I have v18.1.1 and a Clang recipe waiting in the wings :) Pretty please! |
@planetmarshall You probably want to ping one of the team members, although I think they are pretty heads-down right now fixing some of the major problems in CCI. |
prince-chrismc/conan-center-index-pending-review#1 mentions 12 days before raising an alarm so I'll give it another week before pestering anyone. |
@planetmarshall Thanks for updating this recipe btw. I'm more in need of a general |
Pinging @danimtb and @prince-chrismc for review if available. |
I haven't been involved in the project for a while so that table might not reflect the current trends. Nor will I be able to help with reviewing since i haven't used conan in a long while. 🙊 |
Pinging also @ericLemanissier and @RubenRBS Apologies for the spam but keen to move forward with this. Cheers. |
I detected other pull requests that are modifying llvm-core/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
@RubenRBS The build seems to have been stuck in limbo for a while. Are there still CI issues? Thanks. |
Conan v1 pipeline ✔️All green in build 26 (
Conan v2 pipeline ✔️
All green in build 27 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot!
@planetmarshall sorry about that - llvm takes quite a long time to compile - I see that the compilation is now done and the results posted and they are passing, yay!! I'll get a review going for monday, thanks a lot for your patience and for the contribution in the first place, we really aprpeciate it :) |
Thanks, I also appreciate the efforts of the CCI team. |
Specify library name and version: llvm-core/*
Attempt to bring the llvm-core recipe up to date. Includes contributions from @jusito and #17509. Fixes #20339
Note that I have opted not to add the latest version (18.1.3) as part of this PR, as the existing recipe needed updating and is already quite complex. I (or someone else) will add the latest version as a followup.