libffi: Add 3.4.6, remove 3.4.2 and 3.4.3

[Ahajha]

Specify library name and version: libffi/3.4.6

The patch 0007-3.4.3-forward-declare-open_temp_exec_file.patch (and friends) is no longer needed for the new version, as it has been upstreamed.

The MSVC build changed slightly: libffi/libffi@2b2f61f, essentially there's a new FFI_STATIC_BUILD that replaces FFI_BUILDING.

I'm not certain that the FFI_BUILDING/FFI_STATIC_BUILD macros need to be in the package info for non-MSVC builds. I've kept them for now, but maybe we could revisit at some point.

Older versions of libffi don't support Apple ARM CPUs, it looks like there was an attempt to backport the fix, but the patch itself wasn't actually merged: #5085. There are plenty of newer versions so I don't think it's worth fixing at this point. Unsure why this was still an issue.

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[github-actions]

🤖 Beep Boop! This pull request is making changes to 'recipes/libffi//'.

👋 @Hopobcn you might be interested. 😉

[ericLemanissierBot]

I detected other pull requests that are modifying libffi/all recipe:

• libffi 3.4.4 -> 3.4.6 #23066
• libffi: Add version 3.4.5 #22781

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[Ahajha]

@uilianries @RubenRBS Do you think it's about time to remove pre-3.4.4 versions? 3.4.4 is used everywhere (except llvm-core which is still on 3.3, but is being updated in #22997), and is already about two years old, I don't think we need anything older.

[RubenRBS]

Thanks a lot for the detailed PR body, it's super appreciated :)

[Ahajha]

@RubenRBS What do you think about removing the older versions? Only 3.3 is used, and it's by llvm-core, which is getting updated in another PR. 3.4.4 itself has been out for nearly 2 years, I don't think we need anything older.

[uilianries]

@Ahajha you could remove 3.4.3 and 3.4.2. Others I would prefer in another PR, after updating other recipes first. Thank you for checking it.

[Ahajha]

@uilianries I've removed those two versions. I realize my comment wasn't clear, 3.4.4 I think should stay for now (and would have to anyways), 3.3 was the other version that I think should be removed, but I'll wait until the llvm-core PR is merged to do that.

[uilianries]

@Ahajha You need to remove both version from conandata.yml too.

UPDATE: Fixed by dab998a

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 10 (dab998a7d982a10fa9dbc16cf8d27d52003fbfa4):

• libffi/3.4.6:
  All packages built successfully! (All logs)

• libffi/3.3:
  All packages built successfully! (All logs)

• libffi/3.4.4:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 10 (dab998a7d982a10fa9dbc16cf8d27d52003fbfa4):

• libffi/3.4.6:
  All packages built successfully! (All logs)

• libffi/3.4.4:
  All packages built successfully! (All logs)

• libffi/3.3:
  All packages built successfully! (All logs)

[Ahajha]

@uilianries Thanks, was a bit tired last night :)

[uilianries]

@uilianries Thanks, was a bit tired last night :)

Thank you for contributing!!!! 👏

[uilianries]

LGTM

[Croydon]

Please start adding patch_description and patch_type. Additionally patch_source if applicable

[Ahajha]

These were from existing patches, but I can do some digging and figure out their purposes.