github actions: don't use tj-actions/changed-files

[ericLemanissier]

My motivation for not using tj-actions/changed-files actions any more is that:

• it breaks its interface (parameters) often, most release are major releases
• it documents no migration path between major versions
• breaking changes are not clearly identified

And we cannot stay on tj-actions/changed-files/v20 for long because it uses deprecated features which will be removed soon (cf https://github.com/conan-io/conan-center-index/actions/runs/3326299661/jobs/5499882522#step:4:99 https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/)

This PR demonstrates that for CCI's use case (getting files changed in a pull-request), 7 lines of python code are sufficient to do the job, so it feels to me that it's a smaller maintenance burden to use our custom action than tj-actions/changed-files

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the conan-center hook activated.

[prince-chrismc]

I'd like to propose a test.

I want to merge this into my repos master branch. Then have someone without writing access to open a few PRs - We can steal real from from CCI - and make sure we get the correct results.

This is the closest I can think of for a real world test.

Thoughts?

[danimtb]

I'd like to propose a test.

I want to merge this into my repos master branch. Then have someone without writing access to open a few PRs - We can steal real from from CCI - and make sure we get the correct results.

This is the closest I can think of for a real world test.

Thoughts?

ok, let's do that

[prince-chrismc]

prince-chrismc@46bbd46

You should be able to make PRs against my repo :)

also random changes like docs, configs, linters -- this should be a good test 🤞

[prince-chrismc]

Opened prince-chrismc#44 so far so good!

---

I have one small quibble about the order of calling setup-python twice

• we can remove the one in the action assume its there (which it is by default on the runners)
• fix the order in the workflow (but we need to make sure to get it right and thats error prone)

[ericLemanissier]

I don't think it's worth the risk, considering it literally takes 0 seconds to install python.
There is another problem though: only one file of each type is processed, even if each of my PRs modify two of each. I'll take a look later today

EDIT: OK, it's not a change actually it's simply because the linter stops at the first error.
There is another actual problem though: path matching uses fnmatch, which considers * as any character, any number of time, including path separators. The consequence is that the test recipe fall in the recipe bucket too. I'll see if python's glob does what we want

[ericLemanissier]

it looks ok now. see how https://github.com/conan-io/conan-center-index/actions/runs/3487128109/jobs/5834387846 did not lint any file (because it only lints recipes), but https://github.com/conan-io/conan-center-index/actions/runs/3487128109/jobs/5834387983 linted the expected test recipe.

Can you pull this change in your fork @prince-chrismc ?

[conan-center-bot]

Conan v1 pipeline

Changes not allowed in build 31:

[.github/actions/pr_changed_files/action.yml, .github/workflows/linter-conan-v2.yml, .github/workflows/linter-yaml.yml, recipes/aeron/all/test_package/conanfile.py]

Changing recipes and configuration/docs files in the same pull-request is not allowed. Please, split changes into several pull-requests.

[prince-chrismc]

changes are in and I triggered the PRs again 👍

Maybe next week we can get on a Zoom for an hr and just knock this out? it will be slow going back and forth

[prince-chrismc]

The two PRs look really promising. They ran only every necessary so 👍

I'd like to see a docs PR (aka no files changes) and a linter PR just to make sure those two workflows still work 🙏 than I think we can green lite this to go in

[ericLemanissier]

ok, see:

• touch documentation prince-chrismc/conan-center-index#47
• touch linter prince-chrismc/conan-center-index#48

[prince-chrismc]

Everything checks out and looks to be running correctly from a fork 🤞

[uilianries]

LGTM