Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix conandata lint #14393

Merged
merged 4 commits into from
Nov 23, 2022
Merged

fix conandata lint #14393

merged 4 commits into from
Nov 23, 2022

Conversation

ericLemanissier
Copy link
Contributor

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


@ericLemanissier
Copy link
Contributor Author

here we go: the linter crashes with ModuleNotFoundError: No module named 'strictyaml'

@conan-center-bot

This comment has been minimized.

@ericLemanissier
Copy link
Contributor Author

and with the last commit, the linter error is fixed:
https://github.com/conan-io/conan-center-index/actions/runs/3534251171/jobs/5930899853#step:8:2

@ericLemanissier ericLemanissier marked this pull request as ready for review November 23, 2022 17:20
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

Changes not allowed in build 3:

[.github/actions/pr_changed_files/action.yml, recipes/7zip/19.00/conandata.yml]

Changing recipes and configuration/docs files in the same pull-request is not allowed. Please, split changes into several pull-requests.

@ericLemanissier
Copy link
Contributor Author

friendly ping @danimtb @uilianries @prince-chrismc
This fixes conandata linter (without the fix and with the fix)
We did not exercise this linter as part of our tests in #13748 because it is called after yamllint. So yamllint always failed and exited early during the tests we performed, short-circuiting the run of config_yaml_linter. We should be good now

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@conan-center-bot conan-center-bot merged commit bed7a19 into conan-io:master Nov 23, 2022
@ericLemanissier ericLemanissier deleted the patch-1 branch November 23, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants