ArrayLoader: fix integer index of branch alias #10660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
reviewed
Mar 26, 2022
Comment on lines
368
to
369
| $this->assertSame('2019', $package->getSourceReference()); | ||
| $this->assertSame('2019', $package->getDistReference()); |
There was a problem hiding this comment.
The assertion is wrong here, probably should check that we get an alias package with the expected version or something?
There was a problem hiding this comment.
Right, copied this and never updated it. I adjusted the test and I am only calling the getBranchAlias method. I am not sure, I understand what you mean with the alias package. The branch alias will never match because 1 does not match a dev version.
|
Good find, super nasty these numeric array indices.. |
glaubinix
force-pushed
the
f/branch-alias-numeric-array-index
branch
from
a03f403
to
92e47ee
Compare
glaubinix
force-pushed
the
f/branch-alias-numeric-array-index
branch
from
92e47ee
to
f1371d3
Compare
emahorvat52
pushed a commit
to emahorvat52/composer
that referenced
this pull request
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Console Exception: strtolower(): Argument #1 ($string) must be of type string, int given in ArrayLoader.php:440For example, happens for package "silverstripe/crontask" from packagist.org which has an
extrakey with value{"branch-alias":{"1":"1.3.x-dev"}}in version1.x-dev