ArrayLoader: fix integer index of branch alias

composer · Mar 26, 2022 · 92e47ee · 92e47ee
1 parent 61be158
commit 92e47ee
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/Composer/Package/Loader/ArrayLoader.php b/src/Composer/Package/Loader/ArrayLoader.php
@@ -421,6 +421,8 @@ public function getBranchAlias(array $config): ?string
 
         if (isset($config['extra']['branch-alias']) && \is_array($config['extra']['branch-alias'])) {
             foreach ($config['extra']['branch-alias'] as $sourceBranch => $targetBranch) {
+                $sourceBranch = (string) $sourceBranch;
+
                 // ensure it is an alias to a -dev package
                 if ('-dev' !== substr($targetBranch, -4)) {
                     continue;

diff --git a/tests/Composer/Test/Package/Loader/ArrayLoaderTest.php b/tests/Composer/Test/Package/Loader/ArrayLoaderTest.php
@@ -12,6 +12,7 @@
 
 namespace Composer\Test\Package\Loader;
 
+use Composer\Package\AliasPackage;
 use Composer\Package\Loader\ArrayLoader;
 use Composer\Package\Dumper\ArrayDumper;
 use Composer\Package\Link;
@@ -347,4 +348,23 @@ public function testNoneStringSourceDistReference(): void
         $this->assertSame('2019', $package->getSourceReference());
         $this->assertSame('2019', $package->getDistReference());
     }
+
+    public function testBranchAliasIntegerIndex(): void
+    {
+        $config = array(
+            'name' => 'acme/package',
+            'version' => 'dev-1',
+            'extra' => [
+                'branch-alias' => [
+                    '1' => '1.3-dev',
+                ],
+            ],
+            'dist' => [
+                'type' => 'zip',
+                'url' => 'https://example.org/',
+            ],
+        );
+
+        $this->assertNull($this->loader->getBranchAlias($config));
+    }
 }