Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GithubDriver nextPage deprecation notice with no link header #10088

Merged
merged 1 commit into from Sep 3, 2021

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Sep 2, 2021

Currently getting 2 notices on PHP 8.1 (on preview and snapshot channel) Dont get confused by the version number in the path its come from brew but the tested version is Composer version 2.1.6 2021-08-19 17:11:08 and Composer version 2.1-dev (2.1-dev+5b16d61762579fcd86507292789f1c92432d9e8b) 2021-09-02 15:22:14:

Deprecation Notice: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in phar:///usr/local/Cellar/composer/2.0.8/bin/composer/vendor/symfony/console/Descriptor/TextDescriptor.php:120

This one I think was already fixed by the symfony team.

Deprecation Notice: explode(): Passing null to parameter #2 ($string) of type string is deprecated in phar:///usr/local/Cellar/composer/2.0.8/bin/composer/src/Composer/Repository/Vcs/GitHubDriver.php:579

This check if link is actually returning something if not it is ignored.

Reproducable composer.json:

{
    "name": "sulu/sulu",
    "description": "Test",
    "license": "MIT",
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/derrabus/laminas-code.git"
        }
    ],
    "require-dev": {
        "laminas/laminas-code": "dev-bugfix/return-type-will-change as 4.4.3"
    }
}

@alexander-schranz alexander-schranz mentioned this pull request Sep 2, 2021
11 tasks
@alexander-schranz alexander-schranz changed the title Check for returned link header in GithubDriver Fix GithubDriver nextPage deprecation notice with no link header Sep 2, 2021
@Seldaek Seldaek merged commit 73e95aa into composer:master Sep 3, 2021
@Seldaek
Copy link
Member

Seldaek commented Sep 3, 2021

Thanks

@alexander-schranz alexander-schranz deleted the patch-1 branch September 5, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants