New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 8.1 Support #6208
Add PHP 8.1 Support #6208
Conversation
96e7771
to
861d907
Compare
9d70911
to
decb394
Compare
70c91c8
to
e3a2a8a
Compare
e270a71
to
93558cf
Compare
…ly treated as a required
93558cf
to
9420b9b
Compare
@@ -86,7 +90,7 @@ jobs: | |||
phpcr-transport: jackrabbit | |||
dependency-versions: 'lowest' | |||
php-extensions: 'ctype, iconv, mysql, gd' | |||
tools: 'composer:v1' | |||
tools: 'composer:v2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
required to install new packages: https://blog.packagist.com/deprecating-composer-1-support/
/cc @chirimoya
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it clear this would mean newer versions can only be installed when using composer v2. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed with @chirimoya we will fix the 8.1 issues on our side in the 2.2 and 2.3 branches. But only the 2.4 branch we will use the fork in 2.2 and 2.3. So with begin of Sulu 2.4 we require composer 2.
a142e1b
to
db86ae8
Compare
db86ae8
to
05c9c44
Compare
f83142a
to
a0e60cc
Compare
For all subscribing this PR sulu itself will be compatible to PHP 8.1 with the next Versions of 2.2 and 2.3. But if you want to use PHP 8.1 in this projects you need to require an additional package:
Which will provide PHP 8.1 support for |
Laminas-code 4.5 is now also released so its now 8.1 can be used with stable packages. |
What's in this PR?
Add support for PHP 8.1
Why?
The first RC of PHP 8.1 was released https://www.php.net/archive/2021.php#2021-09-02-1, and it would great if sulu could support PHP 8.1. This PR currently should tell us where we need todo some work to get compatible with PHP 8.1.
Checklist:
Packages:
Add compatibility for PHP 8.1 goodby/csv#87 (probably unmaintained)Nice to have:
Changes: