Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.1 Support #6208

Merged

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Sep 2, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #
Related issues/PRs #
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Add support for PHP 8.1

Why?

The first RC of PHP 8.1 was released https://www.php.net/archive/2021.php#2021-09-02-1, and it would great if sulu could support PHP 8.1. This PR currently should tell us where we need todo some work to get compatible with PHP 8.1.

Checklist:

Packages:

Nice to have:

Changes:

@alexander-schranz alexander-schranz marked this pull request as draft September 2, 2021 16:54
@alexander-schranz alexander-schranz added DX Affecting the end developer Feature New functionality not yet included in Sulu labels Sep 2, 2021
@alexander-schranz alexander-schranz force-pushed the feature/php-8-1-compatibility branch 3 times, most recently from 96e7771 to 861d907 Compare September 2, 2021 18:58
@alexander-schranz alexander-schranz force-pushed the feature/php-8-1-compatibility branch 6 times, most recently from 9d70911 to decb394 Compare September 10, 2021 12:03
composer.json Outdated Show resolved Hide resolved
@alexander-schranz alexander-schranz force-pushed the feature/php-8-1-compatibility branch 2 times, most recently from 70c91c8 to e3a2a8a Compare September 14, 2021 16:54
@alexander-schranz alexander-schranz force-pushed the feature/php-8-1-compatibility branch 3 times, most recently from e270a71 to 93558cf Compare November 26, 2021 22:03
@@ -86,7 +90,7 @@ jobs:
phpcr-transport: jackrabbit
dependency-versions: 'lowest'
php-extensions: 'ctype, iconv, mysql, gd'
tools: 'composer:v1'
tools: 'composer:v2'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it clear this would mean newer versions can only be installed when using composer v2. What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @chirimoya we will fix the 8.1 issues on our side in the 2.2 and 2.3 branches. But only the 2.4 branch we will use the fork in 2.2 and 2.3. So with begin of Sulu 2.4 we require composer 2.

@alexander-schranz alexander-schranz marked this pull request as ready for review November 26, 2021 22:17
@alexander-schranz
Copy link
Member Author

For all subscribing this PR sulu itself will be compatible to PHP 8.1 with the next Versions of 2.2 and 2.3. But if you want to use PHP 8.1 in this projects you need to require an additional package:

composer require handcraftedinthealps/goodby-csv:^1.4

Which will provide PHP 8.1 support for goodby/csv package which we forked. Begin from Version 2.4 we will require that package. As it is a new Packagist package from the Begin of Sulu 2.4 sulu is only compatible with Composer 2. See the following blog post by the composer maintainers: https://blog.packagist.com/deprecating-composer-1-support/.

@alexander-schranz alexander-schranz enabled auto-merge (squash) December 2, 2021 12:33
@alexander-schranz alexander-schranz merged commit c3a19eb into sulu:2.2 Dec 2, 2021
@alexander-schranz alexander-schranz deleted the feature/php-8-1-compatibility branch December 2, 2021 13:03
@alexander-schranz
Copy link
Member Author

Laminas-code 4.5 is now also released so its now 8.1 can be used with stable packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer Feature New functionality not yet included in Sulu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants