Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change exit code on empty requirements and fix false positive on php requirement #80

Merged
merged 5 commits into from May 17, 2020

Conversation

icanhazstring
Copy link
Member

@icanhazstring icanhazstring commented May 17, 2020

When there are no packages to scan then there should
be no need to exit the process with an exit code larger than 0.

This should solve a problem for any CI integration for new packages
where composer-unused will be installed and used from the get go.

Solve #78


Also fixed an issue where Core extension was checked as ext-core instead of php
Solve #79

All Submissions:

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

When there are no packages to scan then there should
be no need to exit the process with an exit code larger than 0.

This should solve a problem for any CI integration for new packages
where composer-unused will be installed and used from the get go.
@icanhazstring icanhazstring changed the title Change exit code Change exit code on empty requirements May 17, 2020
Core extension was checked as ext-core which is not correct. This has been solved, so `php` will now be reported as used when any core symbol is used inside the root project.
@icanhazstring icanhazstring changed the title Change exit code on empty requirements Change exit code on empty requirements and fix false positive on php requirement May 17, 2020
@icanhazstring icanhazstring merged commit eca7418 into master May 17, 2020
@icanhazstring icanhazstring deleted the fix/empty-require-error branch May 21, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant