New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php is always marked as unused requirement #79
Comments
Hi again. Thanks for reporting. The scan of core exetnsikns7and the language itself is not very stable. For example if you require a package that uses This should also solve the problem you are describing. I will see to it. Thanks for reporting. |
Thanks for you fast reaction. In case you need any support from my side just give me a note. |
Ok found the bug, as we try to load all classes, constants and function from all "extensions". Only difference is the "core" extension, so I will try and fix this with #78 as they both need a new test implementation. As I said, this issue will be fixed there as well but needs a bit more implementation detail. edit: Solved in #80 as well. |
Nice I'll try ASAP. Thanks for your super fast reaction |
I can confirm that nothing in a psr 4 setup results in a php unused and thus non-zero exit code 👍 and having an empty class is not triggering the php usage 🤔. I do not expect some sort of feature detection check to determine the php version but any php file should trigger the usage of php, doesn't it? Using a function like All in all I'd take it like it is because it is solving my problem. Some edge cases still need to be covered in the future for those weird people with empty php files 😅 |
Yep. Currently extensions as well as core language are only detected if symbols (class, constant, functions) are used. Ofc if you are using plain php without any of those symbols. The language is still "used" 😅 Maybe some improvement in the future 😉 Thanks for testing the changes 👍 |
🥳 |
Describe the bug
A composer.json with a php version constraint gets as output that the php requirement is unused and should be discarded. There is a psr 4 valid class in the src folder that uses a core function. That should count to require any php version.
Error dump
composer.json
Command
Log
The text was updated successfully, but these errors were encountered: