Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add php8.1 build #243

Merged
merged 2 commits into from Dec 14, 2021
Merged

Add php8.1 build #243

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2f9af9
Add php8.1 build
Dec 6, 2021
51c7e56
Use proper php version constraint
Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .docker/php7.4/Dockerfile
View file
Open in desktop
@@ -1,6 +1,7 @@
FROM php:7.4-alpine

COPY --from=mlocati/php-extension-installer /usr/bin/install-php-extensions /usr/bin/
ADD https://github.com/mlocati/docker-php-extension-installer/releases/latest/download/install-php-extensions /usr/bin/
RUN chmod +x /usr/bin/install-php-extensions
RUN install-php-extensions ds xdebug opcache

COPY --from=composer:latest /usr/bin/composer /usr/bin/composer
Expand Down
3 changes: 2 additions & 1 deletion .docker/php8.0/Dockerfile
View file
Open in desktop
@@ -1,6 +1,7 @@
FROM php:8.0-alpine

COPY --from=mlocati/php-extension-installer /usr/bin/install-php-extensions /usr/bin/
ADD https://github.com/mlocati/docker-php-extension-installer/releases/latest/download/install-php-extensions /usr/bin/
RUN chmod +x /usr/bin/install-php-extensions
RUN install-php-extensions ds xdebug opcache

COPY --from=composer:latest /usr/bin/composer /usr/bin/composer
Expand Down
12 changes: 12 additions & 0 deletions .docker/php8.1/Dockerfile
View file
Open in desktop
@@ -0,0 +1,12 @@
FROM php:8.1-alpine

ADD https://github.com/mlocati/docker-php-extension-installer/releases/latest/download/install-php-extensions /usr/bin/
RUN chmod +x /usr/bin/install-php-extensions
RUN install-php-extensions ds xdebug opcache

COPY --from=composer:latest /usr/bin/composer /usr/bin/composer
ENV COMPOSER_ALLOW_SUPERUSER 1

WORKDIR /docker
# Workaround to keep container running
CMD ["tail", "-f", "/dev/null"]
22 changes: 8 additions & 14 deletions .github/workflows/validate-code.yml
View file
Open in desktop
Expand Up @@ -12,8 +12,8 @@ jobs:
strategy:
fail-fast: true
matrix:
os: ["ubuntu-latest"]
php: ["7.4"]
os: [ "ubuntu-latest" ]
php: [ "7.4" ]
steps:
- name: Checkout
uses: actions/checkout@v2.4.0
Expand All @@ -37,8 +37,8 @@ jobs:
strategy:
fail-fast: true
matrix:
php: ["7.4"]
os: ["ubuntu-latest"]
php: [ "7.4" ]
os: [ "ubuntu-latest" ]
steps:
- name: Checkout
uses: actions/checkout@v2.4.0
Expand All @@ -63,12 +63,9 @@ jobs:
strategy:
fail-fast: false
matrix:
php: ["7.4", "8.0"]
os: ["ubuntu-latest"]
experimental: [false]
include:
- php: "8.0"
composer-options: "--ignore-platform-req=php"
php: [ "7.4", "8.0", "8.1" ]
os: [ "ubuntu-latest" ]
experimental: [ false ]

steps:
- name: Checkout
Expand All @@ -93,11 +90,8 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [ "7.4", "8.0" ]
php: [ "7.4", "8.0", "8.1" ]
os: [ "ubuntu-latest" ]
include:
- php: "8.0"
composer-options: "--ignore-platform-req=php"
steps:
- name: Checkout
uses: actions/checkout@v2.4.0
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@
}
],
"require": {
"php": ">=7.3 || ^8.0",
"php": ">=7.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to open it so there's not upper bound and it installs on PHP 15?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I think it's already broken by having >=7.3 so there's not much we can do about the underlying issue.

"composer-plugin-api": "^2.0",
"composer-unused/symbol-parser": "^0.1.3",
"nikic/php-parser": "^4.13",
Expand Down
8 changes: 8 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Expand Up @@ -16,3 +16,11 @@ services:
- .:/docker/composer-unused:rw
- ../symbol-parser:/docker/symbol-parser:rw
tty: true

php8.1:
build: .docker/php8.1
container_name: composer-unused-8.1
volumes:
- .:/docker/composer-unused:rw
- ../symbol-parser:/docker/symbol-parser:rw
tty: true