Add php8.1 build #243
Merged
Add php8.1 build #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Frömer <andreas.froemer@check24.de>
|
Currently blocked by: php-ds/ext-ds#188 as the local docker setup does not work. |
simPod
reviewed
Dec 13, 2021
composer.json
Outdated
| @@ -17,7 +17,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=7.3 || ^8.0", | |||
| "php": ">=7.3", | |||
There was a problem hiding this comment.
Do we want to open it so there's not upper bound and it installs on PHP 15?
There was a problem hiding this comment.
But I think it's already broken by having >=7.3 so there's not much we can do about the underlying issue.
We can compile it from master if it's needed |
Actually no need. The build itself works, so the tool is working for 8.1. It is just a problem for local dev using docker. Only thing that we might need to update some deps to recognize new symbols, like enum |
Signed-off-by: Andreas Frömer <andreas.froemer@check24.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PHP8.1 Build for CI