add phpstan typechecked phpdocs #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2020
staabm
commented
Oct 28, 2020
| @@ -25,6 +25,7 @@ public function meetsCriteria(Node $node): bool | |||
| /** | |||
| * @param Node&ClassConstFetch $node | |||
| * @return array<string> | |||
| * @phpstan-return array<class-string> | |||
| */ | |||
| public function extractNamespaces(Node $node): array | |||
There was a problem hiding this comment.
I am wondering whether these methods should read $class->toCodeString() as it seems toString will not always return a proper FQCN, per phpdocs in
There was a problem hiding this comment.
Hm but as it states toCodeString just used toString
Question is: Is this overridden in some specific types?
There was a problem hiding this comment.
Ok, it is changed depending on Relative or FullyQualified nodes.
That would prepend \\ or namespace\. Which I don't know if it's good.
But it could be a possibility for resolving the problem @OskarStark and @localheinz faced in #100 where
"Relative" classes were not recognized correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Changes to Core Features:
Adding some phpdocs to make it easier to contribute. the question came up in a recent PR and having this types defined makes it easier for humans and also tools to reason about the code.
#100 (comment)