Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add phpstan/psalm class-string types (phpdocs) #726

Closed
staabm opened this issue Oct 28, 2020 · 1 comment
Closed

add phpstan/psalm class-string types (phpdocs) #726

staabm opened this issue Oct 28, 2020 · 1 comment

Comments

@staabm
Copy link
Contributor

staabm commented Oct 28, 2020

would you accept a PR which adds a class-string return type, where appropriate?

this would ease building new tools on top of php-parser, as we could typecheck things on top of it.

recent use-case composer-unused/composer-unused#111

@nikic
Copy link
Owner

nikic commented Oct 28, 2020

At least as used in the PR referenced above, certainly not. Use of class-string is inappropriate in this context, as you are confusing classes in the code using PHP-Parser, and classes in the code parsed by PHP-Parser.

@nikic nikic closed this as completed Oct 28, 2020
@staabm staabm mentioned this issue Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants