Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove constraint for container_name unicity while loading model #619

Merged
merged 1 commit into from Apr 16, 2024

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Apr 11, 2024

such validation should occur later, as we actually select containers to be created

see docker/compose#11619 (comment) for context

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate to lose this validation here but I don't see a better alternative right now :(

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof merged commit 60aa640 into compose-spec:main Apr 16, 2024
8 checks passed
@ndeloof ndeloof deleted the container_name branch April 16, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants